Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Kernel Version >= 5.9 #55

Open
wants to merge 1 commit into
base: touchbar-driver-hid-driver
Choose a base branch
from

Conversation

rado0x54
Copy link

@rado0x54 rado0x54 commented Dec 22, 2020

Fix for #54

Commit of the breaking change of the Kernel: torvalds/linux@78289b4

@JayFoxRox
Copy link

Works for me on mbp14,3 running 5.9.14-arch1-1 👍

Without this patch I'd get the problem described in #54.

Code change looks fine, too.

ronnystandtke added a commit to Lernstick/macbook12-spi-driver that referenced this pull request Dec 27, 2020
@fannullone
Copy link

I have macbbook pro 13,3 and running fc33
I have applied the fix to the apple-ib-als.c:

/* iio_dev = iio_device_alloc(sizeof(als_dev)); */
iio_dev = iio_device_alloc(&als_dev->hid_dev->dev, sizeof(als_dev));

Then
sudo dkms install applespi/0.1 -k 5.9.16-200.fc33.x86_64/x86_64

which worked fine, then rebooted but still touchbar is not working.

The module doesn't seem to be running:
[root@mbp ~]# modprobe apple-ib-tb
[root@mbp ~]# lsmod | grep apple-ib-tb
[root@mbp ~]#

Any idea what I am missing?
Will this fix be available in any upstream kernel for fedora?

@divad42
Copy link

divad42 commented Jan 1, 2021

Do you have usbmuxd installed? usbmuxd breaks the touchbar driver.

@ghost
Copy link

ghost commented Jan 4, 2021

I just forked this. There hasn't been an update here for 11 months and your patch does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants