Fix #674 by explicitly setting return type to float in Cython version of HoppingWindow.ranges() #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the cython stage in Travis would build (I think) but not use the .so files during testing, because of how py.test adds the current working directory to sys.path - the .so files would be installed in the tox virtualenv, but python would import faust from the faust/ directory under the git clone. This made tests that would otherwise fail with the Cython implementation pass, as they were testing the (pure) python implementation of modules. Also adds one test under t/cython that will fail if we can't import a cythonized module, ensuring we get a proper warning if we have an incorrect test environment.
2 tasks
|
Erik Forsberg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #674
Based on #673, or Travis will fail. Will happily rebase onto master once #672 is fixed.
Reorganizes tox a bit, using
--import-mode appendwhen running py.test, as before, the compiled (Cython versions) of modules were not actually tested in the Cython stage on Travis - reason being that due to faust not using asrc/directory layout, unit tests will import faust from the faust/ directory in the git clone, rather than from the version installed in the tox virtualenv.