-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(notebooks): 📝 json and csv sink cookbooks are added #975
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@SkalskiP do you want to merge/review this? |
Hi @onuralpszr 👋🏻, thanks for the reminder.
|
@SkalskiP thank you for tips let me update all. |
Pleasure 💜 |
@SkalskiP I updated both collabs in "the links" could you check, after your confirm I will commit all |
@SkalskiP friendly reminder ping :) |
Hi @onuralpszr , we spoke with Piotr and I'll be reviewing this one |
Hi @onuralpszr, Here's my review comments:
Sinks allow users to serialize data into formats suitable for sharing with others or storage in the filesystem. We should show the deserialization case too!
Seems like a lot of changes - apologies for the hassle! However, we do wish to equip the devs with the exact tools they need to get their problems solved 😉 Let me know if you have any questions! |
@LinasKo, thanks for putting the list together! 🙏🏻 |
Hey @onuralpszr, How's it going? Got any updates for this one? I know you're pretty busy so no rush 🙂 |
Check JSON for development in URL, for update html in commit I will do as last, Don't worry I know that problem ;) I will also remove "loading bar" I am very well aware that problem in the beginning ;) I added docs and changes most of it. I wrote complete convert from json to detections check only json please, I can do docs changes and others on CSV afterwards (%99 percent same) |
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@LinasKo I updated both colabs did some changes please check when you had time, thank you. |
Will do, thank you @onuralpszr ! |
Hi @onuralpszr, Thank you very much for the adjustments! It looks much better now, and I think as a user I'd be able to find what I need. I still have a few requests:
"""
"""
"""
I believe that's everything. Thanks again of the awesome work that you do! |
@LinasKo could you explain 6 again ? I think you meant "json" one for using nothing extra like "pandas" ? |
Certainly. I see now, CSV example does use
For the JSON example, I am torn - I'm not sure if we should try using |
Json doesn't use any pandas at all it just numpy and numpy is already come with sv :) I am confused Where is pandas ? it is "np" not "pd" :) |
Let me clean up bit more okay, but I am kinda close to decide leave this PR as it is and open a new one and add actual "parse json/csv to sv.Detections" and add those into notebook :) |
Yeah, I know it feels like we ought to have it, right? 🙂 Let's not be too hasty though. Let's see whether it's needed first. |
Hey @onuralpszr, Just a quick note - we're thinking of releasing |
I'll get in done. (I have some work to finish) |
I also see some requests about convert back to sv.Det.. . We may re consider. :) |
Description
New JSON and CSV sink cookbooks are added. For Json it needs a version bump, I used the direct
develop
branch while preparing it.JSON collab URL: https://colab.research.google.com/drive/19aqX0QwKXxRk4sYtdEmghO2rzEAKMciM?usp=sharing
CSV collab URL: https://colab.research.google.com/drive/1-qetEcyzrBCOCq-TfVVT8AgUG3rJUhT7?usp=sharing