fix(cjs): should keep correct esm semantic in importing external modules

[hyf0]

Description

[hyf0]

• fix(cjs): should keep correct esm semantic in importing external modules #1172 👈
• feat(rust): render external imports after normal imports #1171
• feat(rust): store package.json in NormalModule #1170
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 94.44444% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.78%. Comparing base (19e8fb8) to head (5c3b4fb).
Report is 3 commits behind head on main.

❗ Current head 5c3b4fb differs from pull request most recent head bfc53db

Please upload reports for the commit bfc53db to get more accurate results.

Files	Patch %	Lines
crates/rolldown_common/src/types/package_json.rs	57.14%	3 Missing ⚠️
...lldown_plugin/src/utils/resolve_id_with_plugins.rs	50.00%	2 Missing ⚠️
...s/rolldown/src/utils/chunk/render_chunk_imports.rs	98.21%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
+ Coverage   86.73%   86.78%   +0.04%     
==========================================
  Files         122      123       +1     
  Lines        6084     6143      +59     
==========================================
+ Hits         5277     5331      +54     
- Misses        807      812       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmarks Rust

• target: 05-20-feat_rust_render_external_imports_after_normal_imports(701b351)
• pr: 05-20-fix_cjs_should_keep_correct_esm_semantic_in_importing_external_modules(5c3b4fb)

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     29.6±0.98ms        ? ?/sec    1.00     29.7±0.68ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     20.7±0.52ms        ? ?/sec    1.00     20.7±0.42ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.03     42.3±2.04ms        ? ?/sec    1.00     41.2±0.98ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    311.8±2.19ms        ? ?/sec    1.00    313.0±1.91ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    204.6±1.97ms        ? ?/sec    1.01    206.6±3.92ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    447.9±9.95ms        ? ?/sec    1.00    445.8±9.26ms        ? ?/sec

Benchmarks Rust

• target: main(f102cc0)
• pr: 05-20-fix_cjs_should_keep_correct_esm_semantic_in_importing_external_modules(bfc53db)

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.02     30.1±1.07ms        ? ?/sec    1.00     29.5±0.43ms        ? ?/sec
rolldown benchmark/threejs-scan            1.01     21.0±0.50ms        ? ?/sec    1.00     20.9±0.15ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.03     42.9±1.03ms        ? ?/sec    1.00     41.5±1.00ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    319.9±2.32ms        ? ?/sec    1.00    318.6±4.03ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.01    208.8±0.98ms        ? ?/sec    1.00    207.2±2.20ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.01    453.8±7.83ms        ? ?/sec    1.00    447.7±9.98ms        ? ?/sec

[codspeed-hq]

CodSpeed Performance Report

Merging #1172 will not alter performance

_{Comparing 05-20-fix_cjs_should_keep_correct_esm_semantic_in_importing_external_modules (bfc53db) with main (f102cc0)}

Summary

✅ 6 untouched benchmarks

[hyf0]

Merge activity

• May 19, 2:54 PM EDT: @hyf0 started a stack merge that includes this pull request via Graphite.
• May 19, 2:57 PM EDT: Graphite rebased this pull request as part of a merge.
• May 19, 2:58 PM EDT: @hyf0 merged this pull request with Graphite.

[netlify]

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	bfc53db
🔍 Latest deploy log	https://app.netlify.com/sites/rolldown-rs/deploys/664a4b671adc340008be6650