Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object: add support for service account authentication in vault #13934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

object: add support for service account authentication in vault #13934

wants to merge 1 commit into from

Conversation

thotz
Copy link
Contributor

@thotz thotz commented Mar 14, 2024 •
edited

Add support for service account authentication with help of vault agent for RGW

Design doc can be found here: #10319

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@thotz
object: add support for service account authentication in vault
6f094d9 
Add support for service account authentication with help of vault agent
for RGW

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Labeled by the stale bot label Apr 22, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

@github-actions github-actions bot closed this May 15, 2024
@BlaineEXE BlaineEXE reopened this May 15, 2024
BlaineEXE
BlaineEXE requested changes May 15, 2024
View reviewed changes
Copy link
Member

@BlaineEXE BlaineEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for review until design doc merged

@github-actions github-actions bot removed the stale Labeled by the stale bot label May 16, 2024
@mergify Mergify
Copy link

mergify bot commented May 16, 2024

This pull request has merge conflicts that must be resolved before it can be merged. @thotz please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlaineEXE BlaineEXE BlaineEXE requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thotz @BlaineEXE