-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
object: create cosi user after successful reconcilation #14020
base: master
Are you sure you want to change the base?
Conversation
Converted to draft since we talked about going a different direction with the fix. |
Objectstore controller creates cosi user before objectstore is ready, it will take sometime to rgw server will up and be ready receive requests via restapi. So creating cosi will fail until rgw is ready. But other users like adminops and dashboard are created with help of `radosgw-admin` command and never fails. So use the same approach for cosi user. Fixes: rook#13904 Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
1d0c0e6
to
1e67dee
Compare
@BlaineEXE @travisn Instead of using adminops apis, use radosgw-admin commands for the cosi user creation. Currently dashboard user is created using the same steps. The |
return reconcile.Result{}, errors.Wrapf(err, "failed to get admin ops API context") | ||
} | ||
if cephObjectStore.Spec.IsExternal() { | ||
adminOpsCtx, err := newMultisiteAdminOpsCtxFunc(objCtx, &cephObjectStore.Spec) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we need to use the admin api for external clusters, but radosgw-admin for local creation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer not do this and always use the admin ops API, even if it takes longer for us to be able to successfully use the commands. We have so many problems with radosgw-admin
that I'd like to use it as infrequently as possible.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
Objectstore controller creates cosi user before objectstore is ready, this create unecessary errors logs mentioning cosi user failed to create.
Fixes: #13904
Checklist: