Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multus: add host checking to validation tool #14230

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BlaineEXE
Copy link
Member

@BlaineEXE BlaineEXE commented May 16, 2024

In order to help users check that they have implemented the newly-added Multus host configuration prerequisites, add a check to the validation tool to verify connectivity.

Because users who are already running clusters with Multus enabled, add a flag that allows users to only check for host configuration prerequisites. This mode will not start the large number of clients that would normally be started because those clients could disrupt a running Rook cluster negatively.

Manual validation tests:

  • flakiness check still works
  • expect to fail when NAD doesn't have route
  • cleanup cleans up host checkers
  • expect to fail when host doesn't have route
  • expect to succeed when NAD and host routing is correct
  • --host-check-only results in tool stopping after host check succeeds
  • --host-check-only exits with early success when public-net is unset
  • tool enters host check only mode when --host-check-only flag AND/OR config file config is set
  • test on openshift
  • update documentation to mention using the validation tool
  • fix KinD-based CI tests

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@BlaineEXE BlaineEXE force-pushed the multus-validation-test-add-host-checking branch 5 times, most recently from 2b5e387 to 0355394 Compare May 20, 2024 22:49
@BlaineEXE BlaineEXE added this to In progress in v1.14 via automation May 28, 2024
In order to help users check that they have implemented the newly-added
Multus host configuration prerequisites, add a check to the validation
tool to verify connectivity.

Because users who are already running clusters with Multus enabled, add
a flag that allows users to only check for host configuration
prerequisites. This mode will not start the large number of clients that
would normally be started because those clients could disrupt a running
Rook cluster negatively.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
@BlaineEXE BlaineEXE force-pushed the multus-validation-test-add-host-checking branch from f96dbc6 to ea13a6a Compare May 31, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v1.14
In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant