Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to update job timeout according to settings #458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eriktelepovsky
Copy link

Ability to change job timeout from its detail. Useful when settings are changed.

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #458 (2bb29bc) into master (ce16f5c) will decrease coverage by 0.84%.
The diff coverage is 12.50%.

❗ Current head 2bb29bc differs from pull request most recent head 1fb0769. Consider uploading reports for the commit 1fb0769 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   89.95%   89.10%   -0.85%     
==========================================
  Files          27       27              
  Lines        1663     1662       -1     
==========================================
- Hits         1496     1481      -15     
- Misses        167      181      +14     
Impacted Files Coverage Δ
django_rq/urls.py 100.00% <ø> (ø)
django_rq/views.py 82.86% <12.50%> (-4.17%) ⬇️
django_rq/tests/tests.py 93.83% <0.00%> (-0.17%) ⬇️
django_rq/queues.py 87.69% <0.00%> (ø)
django_rq/templatetags/django_rq.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3f945...1fb0769. Read the comment docs.

@selwin
Copy link
Collaborator

selwin commented Jan 26, 2021

Sorry for the late reply. It would be much more useful if the user himself can specify the timeout. Can you add an intermediary step where the user can specify the new desired timeout?

@rsoltys
Copy link

rsoltys commented Dec 13, 2023

Update of timeout according to the new setting would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants