rtic-macros: fix #[cfg] for hardware and software tasks #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalegaard
force-pushed
the
fix_cfg_tasks
branch
3 times, most recently
from
b5b0370
to
1f7e46e
Compare
dalegaard
force-pushed
the
fix_cfg_tasks
branch
2 times, most recently
from
c861b93
to
afd506f
Compare
|
Hi, Updated this to work with changes in 2.1 release. Best regards, |
Disabling hardware and software tasks via `#[cfg]` flags was broken. Added test case to verify, and fixed codegen to output missing cfgs.
dalegaard
force-pushed
the
fix_cfg_tasks
branch
from
afd506f
to
a330ded
Compare
|
Rebased to master. Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Disabling hardware and software tasks via
#[cfg]flags was broken. Added test case to verify, and fixed codegen to output missing cfgs.Best regards,
Lasse