Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug #20451] merge revision(s) a4ad6bd9aac564e93219284c912b26a72f9e82fc: #10696

Closed
wants to merge 1 commit into from

Conversation

nobu
Copy link
Member

@nobu nobu commented May 1, 2024

https://bugs.ruby-lang.org/issues/20451

[ruby/fiddle] closure: free resources when an exception is raised in
 Closure.new

GitHub: GH-102

https://github.com/ruby/fiddle/commit/81a8a56239
---
 ext/fiddle/closure.c | 56 ++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 43 insertions(+), 13 deletions(-)

	[ruby/fiddle] closure: free resources when an exception is raised in
	 Closure.new

	GitHub: rubyGH-102

	ruby/fiddle@81a8a56239
	---
	 ext/fiddle/closure.c | 56 ++++++++++++++++++++++++++++++++++++++++------------
	 1 file changed, 43 insertions(+), 13 deletions(-)
@adfoster-r7
Copy link

Just as a datapoint; I've confirmed that this fixes my issue when compiling on an older centos build 👍

Before - failure:

21:14:46 ../.././include/ruby/internal/core/rregexp.h:106:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
21:14:46 closure.c: In function ‘initialize’:
21:14:46 closure.c:279:60: error: ‘data’ undeclared (first use in this function)
21:14:46 closure.c:279:60: note: each undeclared identifier is reported only once for each function it appears in
21:14:46 make[2]: *** [closure.o] Error 1

After - success:

compiling closure.c
...
installing default gems from ext:   
...
                                    fiddle 1.1.0
...

@hsbt hsbt closed this May 23, 2024
@hsbt
Copy link
Member

hsbt commented May 23, 2024

@adfoster-r7 Thanks for your confirmation. I merged this at #10826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants