Use spaces around => in Hash#inspect for symbol keys that would generate invalid syntax #10737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate invalid syntax Fixes [Bug #20433]
…generate invalid syntax Related to [Bug #20433]
| @@ -3449,7 +3450,18 @@ inspect_i(VALUE key, VALUE value, VALUE str) | |||
| rb_enc_copy(str, str2); | |||
| } | |||
| rb_str_buf_append(str, str2); | |||
| rb_str_buf_cat_ascii(str, "=>"); | |||
| if (RB_SYMBOL_P(key)) { | |||
| switch (*(RSTRING_PTR(str) + RSTRING_LEN(str) - 1)) { | |||
There was a problem hiding this comment.
This is a bit nitpicky, but are symbols guaranteed to be in any particular encoding? This check might incorrectly not-space a symbol that does need it?
Maybe the way to go is to just change the separator to " => " unconditionally, then we don't have to play this game.
There was a problem hiding this comment.
I'm not opposed to always having spaces, but that is a much less compatible change that probably needs approval from Matz. I'm not sure whether there are other failing cases besides the ones reported in the bug report (this one fixes the problematic cases specified in the bug report). Symbols can be in any encoding, but inspect does not try to dump the encoding information.
KJTsanaktsidis
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use spaces around => in PP.pp for hashes with symbol keys that would generate invalid syntax.
Fixes [Bug #20433]