Fix String#index to clear MatchData when a regexp is passed
#10751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
ruby-3.2-string-index-match-data-clear
branch
from
3cd85cf
to
1f946b4
Compare
[Bug #20421] The bug was fixed in Ruby 3.3 via 9dcdffb
casperisfine
force-pushed
the
ruby-3.2-string-index-match-data-clear
branch
from
1f946b4
to
ea995fe
Compare
eregon
approved these changes
May 14, 2024
|
Ah oops I should not have merged this, but have waited for @nagachika, sorry. |
|
I checked the patch afterward. OK I updated the redmine ticket with Backport field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bug #20421]
The bug was fixed in Ruby 3.3 via 9dcdffb