Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestPatternMatching#test_deconstruct_keys test #10757

Merged

Conversation

andrykonchin
Copy link
Member

Before the change C.keys returned keys captured in some previous test case that by chance captures nil value what made this test passed successfully. Now C.keys returns keys captured in this test case.

Before the change `C.keys` returned keys captured in some previous test case that by chance captured `nil` value what made this test passed successfully. Now it returns keys captured in this test case.
@andrykonchin
Copy link
Member Author

Is there anything I can do to have CI passed (a single failure seems irrelevant to the change) and this PR merged?

The failure is:

[721/885] 3312=test_sleep
  NMAKE : fatal error U1058: terminated by user
  Stop.
  Terminate batch job (Y/N)? 
  #<Thread:0x00000131edb21798 D:/a/ruby/ruby/src/test/ruby/test_io.rb:890 run> terminated with exception (report_on_exception is true):
  [722/885] 3312=test_name_error
  D:/a/ruby/ruby/src/test/ruby/test_io.rb:890:in 'IO#read': stream closed in another thread (IOError)
  [723/885] 5[816](https://github.com/ruby/ruby/actions/runs/9030242216/job/24814120038?pr=10757#step:24:817)=json_string_matching_test
  	from D:/a/ruby/ruby/src/test/ruby/test_io.rb:890:in 'block (3 levels) in TestIO#test_copy_stream_socket3'
  [724/885] 5732=test_safe_load

@k-tsj k-tsj merged commit b60f094 into ruby:master May 14, 2024
100 of 101 checks passed
@k-tsj
Copy link
Member

k-tsj commented May 14, 2024

@andrykonchin
It seems failed spec is not related to the change, so I merged your PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants