Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image_documents at call time for MultiModalLLMCompletionProgram #13467

Merged
merged 3 commits into from
May 14, 2024

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented May 13, 2024

Description

  • For MultiModalLLMCompletionProgram, only images passed during construction time are used for program execution
  • This PR adds the ability to supply a sequence of images at call/execution time
  • Supplied images at call time will take precedence to any images defined at construction time

Fixes # (issue)

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • NA (modification to core)

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new notebook (that tests end-to-end) (to be published in a separate PR)
  • I stared at the code and made sure it makes sense

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 14, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) May 14, 2024 17:04
@logan-markewich logan-markewich merged commit fa2639b into main May 14, 2024
8 checks passed
@logan-markewich logan-markewich deleted the nerdai/gpt-4o-tests branch May 14, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants