RUN-2136: Fix step and node step plugin translation #8802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdevans
changed the title
leandromqrs
force-pushed
the
fix-plugin-translation
branch
from
3a9cf1d
to
228c765
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
2 times, most recently
from
d9d841f
to
9bc06ec
Compare
ltamaster
force-pushed
the
fix-plugin-translation
branch
from
9bc06ec
to
d9d841f
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
4 times, most recently
from
40e4ef4
to
7d88005
Compare
|
I can't wait for it to be merged so I can contribute with my translations. |
leandromqrs
force-pushed
the
fix-plugin-translation
branch
4 times, most recently
from
a2cb6b9
to
f7563d1
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
3 times, most recently
from
3218223
to
28841d2
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
3 times, most recently
from
cf9201e
to
630a51d
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
2 times, most recently
from
c40784a
to
80e98c9
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
from
80e98c9
to
c757b13
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
from
c757b13
to
fe00729
Compare
|
@ltamaster sorry for the question, but, why it is not merged yet ? It's a very simple fix 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Bug fix when try to translate the step and node step plugins to another language.
Describe the solution you've implemented
When the messagePrefix is null, it puts the value of the property as
nullproperty.something.title. After the fix, with the verification if is null, it puts with the correct valueproperty.something.titleDescribe alternatives you've considered
Additional context
Additional images to compare the before and after...
Before
After
Before
After
