RCLOUD-1131: Refactor job service and provider #9117
+513
−402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseOrtiz
force-pushed
the
RCLOUD-1131-job-service-refactor
branch
2 times, most recently
from
eba46a9
to
673356c
Compare
sjrd218
approved these changes
May 13, 2024
JoseOrtiz
force-pushed
the
RCLOUD-1131-job-service-refactor
branch
from
673356c
to
ffb1025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Enhancement. The business logic for saving a JobData was inside the provider that nees to be changed.
Describe the solution you've implemented
An existing service is used to collect all the saving logic
Describe alternatives you've considered
Additional context