Note for E0599 if shadowed bindings has the method. #124283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #125076) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
approved these changes
May 18, 2024
Comment on lines
534
to
535
| "there's an earlier shadowed binding `{rcvr_name}` of type `{self_ty}` \ | ||
| that *has* method `{method_name}` available" |
There was a problem hiding this comment.
Suggested change
| "there's an earlier shadowed binding `{rcvr_name}` of type `{self_ty}` \ | |
| that *has* method `{method_name}` available" | |
| "there's an earlier shadowed binding `{rcvr_name}` of type `{self_ty}` \ | |
| that has method `{method_name}` available" |
| false | ||
| } | ||
|
|
||
| fn check_and_add_sugg_binding(&mut self, binding: LetStmt) -> bool { |
There was a problem hiding this comment.
More detailed comments inside of this method would be useful to allow people to skip the method with more ease.
There was a problem hiding this comment.
More detailed comments inside of this method would be useful to allow people to skip the method with more ease.
Done. Thank you.
Thank you very much. Please help me review again. |
|
There are a few typos in the comments and formatting issues that @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 20, 2024
Note for E0599 if shadowed bindings has the method. implement rust-lang#123558 Use a visitor to find earlier shadowed bingings which has the method. r? `@estebank`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124050 (Remove libc from MSVC targets) - rust-lang#124283 (Note for E0599 if shadowed bindings has the method.) - rust-lang#125123 (Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:Cursor`) - rust-lang#125158 (hir pretty: fix block indent) - rust-lang#125298 (Add codegen test for array comparision opt) - rust-lang#125332 (Update books) Failed merges: - rust-lang#125310 (Move ~100 tests from tests/ui to subdirs) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#124050 (Remove libc from MSVC targets) - rust-lang#124283 (Note for E0599 if shadowed bindings has the method.) - rust-lang#125123 (Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:Cursor`) - rust-lang#125158 (hir pretty: fix block indent) - rust-lang#125308 (track cycle participants per root) - rust-lang#125332 (Update books) - rust-lang#125333 (switch to the default implementation of `write_vectored`) - rust-lang#125346 (Remove some `Path::to_str` from `rustc_codegen_llvm`) Failed merges: - rust-lang#125310 (Move ~100 tests from tests/ui to subdirs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2024
Rollup merge of rust-lang#124283 - surechen:fix_123558, r=estebank Note for E0599 if shadowed bindings has the method. implement rust-lang#123558 Use a visitor to find earlier shadowed bingings which has the method. r? ``@estebank``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #123558
Use a visitor to find earlier shadowed bingings which has the method.
r? @estebank