docs: add instructions for derive macro dynamic implementation #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhenchen Wang <m202372036@hust.edu.cn>
Placebo27
force-pushed
the
placebo27/docs
branch
5 times, most recently
from
065e0f5
to
1feb9bf
Compare
Signed-off-by: DongQing <placebo27@hust.edu.cn>
docs: add documents for #[rustsbi(dynamic)].
duskmoon314
approved these changes
May 13, 2024
There was a problem hiding this comment.
LGTM. I wonder whether doc is more appropriate than lib in the commit message. @luojia65
Placebo27
changed the title
luojia65
approved these changes
May 13, 2024
There was a problem hiding this comment.
Nice catch, LGTM. Following the Conventional Commits specification, the modified title is properly prefixed with docs.
YdrMaster
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #67 , #68 and #69 , the
#[rustsbi(dynamic)]macro implementation can dynamically adapt extensions.However, this section is not in the current documentation, which has been updated for completeness and to make it easier for readers to learn about the latest dynamic features. Now we can see the usage of the section and an example description in the documentation are as follow:
Usage
Example
This pull request add usage and an example for dynamic implementations to the Derive Macro documentation.
Contributors to this pull request: special thanks to @Plucky923 for contributions on this pull request.