Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing filtering for active plugins on manager #15946

Merged
merged 1 commit into from
May 10, 2024

Conversation

Air-t
Copy link
Member

@Air-t Air-t commented May 9, 2024

I want to merge this change because it fixes filtering for active plugins in the manager method.
This also fixes part of the RecursionError

Port: #15943
Fixes: https://linear.app/saleor/issue/SHOPX-665/fix-for-run-plugin-method-until-first-success

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

@Air-t Air-t added bug 3.16 shopping Shopping Experience team topics labels May 9, 2024
@Air-t Air-t self-assigned this May 9, 2024
@Air-t Air-t force-pushed the 3.16-fix-active-plugin-filtering branch from 7432ca5 to 85df416 Compare May 9, 2024 11:30
@Air-t Air-t requested a review from a team May 9, 2024 11:54
@db-queries
Copy link

db-queries bot commented May 9, 2024

Here is the report for 85df416 (saleor:3.16-fix-active-plugin-filtering)
Missing base report (a429349). The results couldn't be compared.

No differences were found.

@Air-t Air-t requested a review from a team May 9, 2024 13:11
@Air-t Air-t merged commit cd445a1 into 3.16 May 10, 2024
3 checks passed
@Air-t Air-t deleted the 3.16-fix-active-plugin-filtering branch May 10, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.16 bug shopping Shopping Experience team topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants