Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor login form #1049

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

grzegorzpokorski
Copy link
Contributor

Few accessibility related touches.

Copy link

vercel bot commented Nov 27, 2023

@grzegorzpokorski is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

@zaiste
Copy link
Contributor

zaiste commented Nov 28, 2023

@grzegorzpokorski let's not nest components in components, our goal is to have a flat file structure with components separated between ui/components and ui/atoms e.g. LoginButton could be in ui/atoms

@grzegorzpokorski
Copy link
Contributor Author

grzegorzpokorski commented Nov 28, 2023

@grzegorzpokorski let's not nest components in components, our goal is to have a flat file structure with components separated between ui/components and ui/atoms e.g. LoginButton could be in ui/atoms

Thank you for the clarification! Initially, this component was located next to the cart page in the src/app/[channel]/(main)/login directory. Perhaps I should move this component back to that directory? What do you think? Should I place components next to the pages files? Answers would make that topic more clear for me 🙂

@grzegorzpokorski
Copy link
Contributor Author

@grzegorzpokorski let's not nest components in components, our goal is to have a flat file structure with components separated between ui/components and ui/atoms e.g. LoginButton could be in ui/atoms

I apologize for any confusion. I will keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants