Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templateParser.php to parse Quote Discount in pdf #10385

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

IsmailHamdi
Copy link

@IsmailHamdi IsmailHamdi commented Mar 24, 2024

Description

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Mar 24, 2024

CLA assistant check
All committers have signed the CLA.

@IsmailHamdi
Copy link
Author

CLA assistant check All committers have signed the CLA.

Done

@serhiisamko091184 serhiisamko091184 added the Status:Requires Updates Issues & PRs which requires input or update from the author label Mar 25, 2024
@serhiisamko091184
Copy link
Contributor

Hello @IsmailHamdi,

thanks for contributing to the SuiteCRM project,

would you be so kind:

  1. to be more specific and fill the template with replication steps and screenshots, if possible, or link this PR to the particular issue registered;

  2. to update the commit message according to the format on the screenshot (if there is no specific issue to address, use the number of this PR - 10385):

image

More information to get acquainted: https://docs.suitecrm.com/community/contributing-code/bugs/

Many thanks in advance!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants