New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(orjson): Add support for orjson #1286

Open

hannotauber wants to merge 1 commit into sammchardy:master from hannotauber:feat/orjson

hannotauber commented Feb 6, 2023

At some point ujson was used for json loads #383 but it does not seem to be the case any more. This code has be lost. I do in v1.0.16

[hannotauber@toolbox python-binance]$ grep -r ujson
docs/changelog.rst:- Stock json lib to ujson (https://github.com/sammchardy/python-binance/pull/383)
requirements.txt:ujson
setup.py:        'requests', 'six', 'dateparser', 'aiohttp', 'ujson', 'websockets'

I am more confident with the work and benchmark results of orjson along with the licensing which comes with Apache 2 and MIT licenses.


          feat(orjson): Add support for orjson

4cc77ba

Owner

sammchardy commented Feb 18, 2023

@hannotauber orjson also requires Rust and can't be installed under some interpreters.

A better option would be allowing to pass a json serializer into the Client so that any could be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment