Fix preview mouse position on Windows #664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix preview mouse position on Windows On Windows, if the screen resize is not 1, the device resolution might be different from the mouse resolution. The "touch_down" and "touch_up" event use the device resolution, but the "on_mouse_pos" event use the mouse resolution. So the mouse position is not correct. We need to convert the mouse position to the device resolution. 2. Improve performance of find preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "touch_down" and "touch_up" event use the device resolution, but the "on_mouse_pos" event use the mouse resolution. So the mouse position is not correct. We need to convert the mouse position to the device resolution.