Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CLI options to enable auto-updating studios #6514

Draft
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

ricokahler
Copy link
Contributor

@ricokahler ricokahler commented Apr 29, 2024

Description

Adds the --enable-auto-updates and unstable_enableAutoUpdates flags to the CLI build options and config.

Additionally this PR:

  • Adds importMap support to renderDocument and sanityBuildEntries via node-html-parser (see tests)
  • Refactors the external array to derive the external values from the specified import map.

Note that this will only affect the built version of the Studio and local versions will not use import maps. This decision was made because we did not want to provide a react dev build however this could potentially be possible now with import maps.

What to review

  • Review the logic, did I miss anything?
  • Take a look at the tests, ensure the import map is being added correctly.

Testing

I added tests and I tried this out in the test-studio locally.

Notes for release

N/A

@ricokahler ricokahler requested a review from a team as a code owner April 29, 2024 15:56
@ricokahler ricokahler requested review from rexxars and removed request for a team April 29, 2024 15:56
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview May 22, 2024 8:50pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 8:50pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 8:50pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 8:50pm

@ricokahler ricokahler requested a review from binoy14 April 29, 2024 15:56
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Component Testing Report Updated May 22, 2024 8:52 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 15s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 4s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 6s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 29s 12 0 0

Copy link

socket-security bot commented Apr 29, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@binoy14 binoy14 marked this pull request as draft May 15, 2024 16:26
@binoy14 binoy14 force-pushed the sdx-1242 branch 2 times, most recently from 0429840 to 5a2b02f Compare May 16, 2024 15:11
Copy link
Contributor

binoy14 commented May 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ricokahler and the rest of your teammates on Graphite Graphite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants