Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fixes issue with history loading indefinitely #6539

Merged
merged 1 commit into from May 14, 2024
Merged

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented May 1, 2024

Description

Fixes issue with history just hanging indefinitely

What to review

Changes makes sense, using suggested code from Rob

Testing

This one is very hard to test, since you need to be able to have a way to create a massive history on a document. This is something for us to look at making it easier

Notes for release

Fixes an issue where history menu would sometimes keep loading indefinitely

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview May 14, 2024 2:05pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 2:05pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 2:05pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 2:05pm

Copy link
Contributor Author

binoy14 commented May 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @binoy14 and the rest of your teammates on Graphite Graphite

Copy link
Contributor

github-actions bot commented May 1, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented May 1, 2024

Component Testing Report Updated May 14, 2024 2:10 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 23s 9 0 0

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that it fixes a case of infinite loading we have seen earlier.
Approving without automated tests as we currently don't have an easy way to mock the history of a document.

@rexxars rexxars added this pull request to the merge queue May 14, 2024
Merged via the queue into next with commit 035b0a0 May 14, 2024
39 checks passed
@rexxars rexxars deleted the bug/sdx-815 branch May 14, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants