-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fixes issue with history loading indefinitely #6539
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
No changes to documentation |
Component Testing Report Updated May 14, 2024 2:10 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that it fixes a case of infinite loading we have seen earlier.
Approving without automated tests as we currently don't have an easy way to mock the history of a document.
Description
Fixes issue with history just hanging indefinitely
What to review
Changes makes sense, using suggested code from Rob
Testing
This one is very hard to test, since you need to be able to have a way to create a massive history on a document. This is something for us to look at making it easier
Notes for release
Fixes an issue where history menu would sometimes keep loading indefinitely