feat(cli): remove is-builtin-module #6579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `is-builtin-module` package since all node versions within our `engine` constraint already have such a function built in. This also allows us to remove the temporary workaround we had around `string_decoder/` since the built in function will not have such a bug.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@43081j is attempting to deploy a commit to the Sanity Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
is-builtin-modulepackage since all node versions within ourengineconstraint already have such a function built in.This also allows us to remove the temporary workaround we had around
string_decoder/since the built in function will not have such a bug.What to review
The CLI should be the only affected package.
Testing
Existing tests should cover this.
Notes for release
N/A