fix(pte): cursor presence causes pte error #6622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated May 13, 2024 4:23 PM (UTC)
|
Since the leaf is now properly rendered for the presence decorator, we are interested in the next nextSibling
skogsmaskin
previously approved these changes
May 13, 2024
There was a problem hiding this comment.
Great catch @pedrobonamin, thank you for this!
I've updated the test to reflect the new DOM structure.
skogsmaskin
approved these changes
May 14, 2024
ricokahler
pushed a commit
that referenced
this pull request
May 14, 2024
* fix(pte): cursor presence causes pte error * test(playwright-ct): fix outdated test Since the leaf is now properly rendered for the presence decorator, we are interested in the next nextSibling * fix(pte): update tests --------- Co-authored-by: Per-Kristian Nordnes <per.kristian.nordnes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Structure consistently crashes with
Cannot resolve a DOM point from Slatepoint when editing a document with multiple usersI've been debugging this and it seems to be generated because the
PresenceCursorelement is not rendering theLeafthat is generated in the editable component, which causes that the editable leaf "dissapears" and crashes the editor.This were the original steps to reproduce the issue:
Steps to reproduce
With the changes introduced I was not able to reproduce the issue anymore,
User 1's structure will then crash
What to review
Testing
Notes for release