fix(core): avoid attribute names being scanned as symbols. Fixes #5673 #6624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
runeb
changed the title
runeb
changed the title
|
Component Testing Report Updated May 21, 2024 4:16 PM (UTC)
|
jtpetty
reviewed
May 10, 2024
| @@ -183,6 +183,10 @@ const cases = { | |||
| }, | |||
| ], | |||
| }, | |||
| trueOrFalseField: { | |||
There was a problem hiding this comment.
should we add a test that fails if this name is just true or false to make sure we didn't just break something?
There was a problem hiding this comment.
Added explicit tests for parsing symbols versus attributes/identifiers
jtpetty
reviewed
May 10, 2024
| // need to make sure we don't inadvertently treat an attribute as a | ||
| // symbol. For example, an attribute 'trueCustomerField' should not be | ||
| // scanned as the boolean symbol "true". | ||
| if (str[0].match(attributeCharMatcher)) { |
There was a problem hiding this comment.
do we know what the perf hit is on looking ahead on each match?
There was a problem hiding this comment.
It would only do this extra check when it encounters a symbol match which is all attribute-valid chars, meaning "true" and "false"
bjoerge
previously approved these changes
May 16, 2024
runeb
changed the title
merged in |
bjoerge
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the mutator package, we scan for certain symbols, among them "true" and "false". If an attribute name is prefixed with a symbol value, the string scanning will eagerly interpret it as a symbol instead of an attribute. This patch checks that there is no more valid attribute characters immediately after the potential symbol, so that the string "trueAttribute" will not be interpreted as the symbol "true".