Improve catching of Swift Errors. #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use NS_ERROR_ENUM and NSErrorDomain in Objective-C, which works nicely in NSError and as Swift Error. Errors can now be catched as `catch DiskError.noFileFound` without introducing a source breaking change.
craigrouse
added a commit
to craigrouse/Disk
that referenced
this pull request
May 29, 2019
|
@saoudrizwan Do you have any reasons or concerns why this PR isn't merge yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use NS_ERROR_ENUM and NSErrorDomain in Objective-C, which works nicely in NSError and as Swift Error. Errors can now be catched as
catch DiskError.noFileFoundwithout introducing a source breaking change.I updated the sample project to take advantage of the change.