feature/maybe seed rng #509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add randomized fields to Engine structs in tests - Implement cryptographically secure random utility functions - Address golangci-lint warnings
- Avoid big package - Use strings.Builder for efficient string concatenation - Set default string length to 10 - Handle errors from rand.Read() Resolves: sashabaranov#487
- Memory efficient solution for RandomInt func - Improve error handling by logging them vice returning the type - Use RandomInt() instead Resolves: sashabaranov#487
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
+ Coverage 97.30% 97.58% +0.28%
==========================================
Files 18 19 +1
Lines 780 871 +91
==========================================
+ Hits 759 850 +91
Misses 15 15
Partials 6 6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A similar PR may already be submitted!
Please search among the Pull request before creating one.
If your changes introduce breaking changes, please prefix the title of your pull request with "[BREAKING_CHANGES]". This allows for clear identification of such changes in the 'What's Changed' section on the release page, making it developer-friendly.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.
Describe the change
Please provide a clear and concise description of the changes you're proposing. Explain what problem it solves or what feature it adds.
Describe your solution
Describe how your changes address the problem or how they add the feature. This should include a brief description of your approach and any new libraries or dependencies you're using.
Tests
Briefly describe how you have tested these changes.
Additional context
Add any other context or screenshots or logs about your pull request here. If the pull request relates to an open issue, please link to it.
Issue: #487