[backport] desugar switchable matches with guards in async methods #10779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The async transformation supports `Match` trees that are left in place
for the backend to emit a switch in bytecode.
Guards are desugared into a jump to the default case
case 22 if p => 5
case _ => 6
becomes
case 22 => if (p) 5 else default()
case _ => default: { 6 }
This pattern is unexpected for the async transform and leads to
invalid bytecode if the guard `p` has an await call.
The fix is to desugar switchable matches with guards in patmat
if the enclosing method has the `AsyncAttachment`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10775
The async transformation supports
Matchtrees that are left in place for the backend to emit a switch in bytecode.Guards are desugared into a jump to the default case
becomes
This pattern is unexpected for the async transform and leads to invalid bytecode if the guard
phas an await call.The fix is to desugar switchable matches with guards in patmat if the enclosing method has the
AsyncAttachment.