New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport "Export diagnostics (including unused warnings) to SemanticDB" #20315
base: lts-3.3
Are you sure you want to change the base?
Conversation
@@ -1364,6 +1364,7 @@ Occurrences: | |||
|
|||
Diagnostics: | |||
[30:12..30:17): [warning] unused explicit parameter | |||
[48:13..48:13): [warning] `:` after symbolic operator is deprecated; use backticks around operator instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[30:11..30:18): [warning] unset local variable, consider using an immutable val instead | ||
[30:20..30:28): [warning] unset local variable, consider using an immutable val instead | ||
[31:15..31:25): [warning] unset local variable, consider using an immutable val instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[24:53..24:63): [warning] An inline given alias with a function value as right-hand side can significantly increase | ||
generated code size. You should either drop the `inline` or rewrite the given with an | ||
explicit `apply` method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests look good
Backports #17835 from @tanishiking to the LTS branch. Fixes (again) #17535, so that library authors stuck on LTS can benefit from it, at the very least through scalafix & metals.