Less verbose creation of ScalastyleConfiguration #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.10% (diff: 0.00%)
|
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 62 62
Lines 1495 1496 +1
Branches 146 148 +2
=====================================
- Misses 1495 1496 +1
Continue to review full report at Codecov.
|
Decreasing the verboseness of `ScalastyleConfiguration` creation can be useful, for example, to the substitution of the process of parsing the XML configuration file by the manual creation of the object itself in Scala (which is "type-safer") in the SBT plugin. This adds default parameters to `ScalastyleConfiguration` and a new `apply` to `ConfigurationChecker` that uses a `ClassTag` to get the class name.
andrelfpinto
force-pushed
the
topic/no-xml-in-sbt
branch
from
e46758c
to
64c0184
Compare
|
Hi, @matthewfarwell, is this PR reasonable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decreasing the verboseness of
ScalastyleConfigurationcreation can be useful, for example, to the substitution of the process of parsing the XML configuration file by the manual creation of the object itself in Scala (which is "type-safer") in the SBT plugin.This adds default parameters to
ScalastyleConfigurationand a newapplytoConfigurationCheckerthat uses aClassTagto get the class name.