Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore magic number for named argument #290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gmarti
Copy link

@gmarti gmarti commented Nov 23, 2017

Magic number should probably not be reported when using named argument

Please let me know if something is wrong, first PR here.

Added tests too

@codecov-io
Copy link

codecov-io commented Nov 23, 2017

Codecov Report

Merging #290 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #290   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          62     62           
  Lines        1495   1503    +8     
  Branches      146    143    -3     
=====================================
- Misses       1495   1503    +8
Impacted Files Coverage Δ
...rg/scalastyle/scalariform/MagicNumberChecker.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8623a18...be6c773. Read the comment docs.

@matthewfarwell
Copy link
Member

Sorry I've been so long in responding to this, this slipped underneath my radar.

I would love this as a PR, but I think it should be an option to the checker. Maybe something like allowNamedArguments, which would be a boolean, default false?

@gmarti
Copy link
Author

gmarti commented Mar 26, 2018

Thx for taking the time to check this PR. I have added the option to the checker defaulted to false.

@gmarti
Copy link
Author

gmarti commented Sep 4, 2018

Any news ?

@weixu365
Copy link

Any news on this PR? We are using lots of named parameters, and have to struggle with the magic number rule for now. It would be awesome if this could be merged

@gmarti
Copy link
Author

gmarti commented Nov 20, 2018

@matthewfarwell ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants