New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH add possibility to have a callable for verbose_feature_names_out of ColumnTransformer #28934
base: main
Are you sure you want to change the base?
Conversation
…of ColumnTransformer
❌ Linting issuesThis PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling You can see the details of the linting issues under the
|
cc @thomasjpfan pretty sure we had the conversation about this at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
…ColumnTransformer also: improve doc for the parameter, fix validation
Hey, just added the possibility to use string format. I also added unit tests. One of the test I created creates name clashing, and I remember seeing something about that somewhere in sklearn's doc. However, I can't seem to put my hand on it. From the behaviour of ColumnTransformer, I know it is not important since it uses np arrays rather than pandas dataframe, but do you think we should issue a warning somewhere in the doc? |
What does this implement?
This brings the possibility to pass a callable to the
verbose_feature_names_out
parameter ofColumnTransformer
. Instead of the new feature name being "transormer_name__feature_name", we could have "feature_name$this is amazing$TRANSFORMER_NAME".Any other comments?
I have a few questions:
.. versionchanged
?In advance, thank you for your time.