Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC add link for NearestCentroid example #28984

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

J-Enblom
Copy link

@J-Enblom J-Enblom commented May 9, 2024

Reference Issues/PRs

#26927

What does this implement/fix? Explain your changes.

This PR adds a link to plot_nearest_centroid.py in _nearest_centroid.py for the NearestCentroid class.

Copy link

github-actions bot commented May 9, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8e5ea8e. Link to the linter CI: here

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Comment on lines 32 to 33
For sample usage of NearestCentroid, refer to
:ref:`sphx_glr_auto_examples_neighbors_plot_nearest_centroid.py`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For sample usage of NearestCentroid, refer to
:ref:`sphx_glr_auto_examples_neighbors_plot_nearest_centroid.py`
For a more detailed example see:
:ref:`sphx_glr_auto_examples_neighbors_plot_nearest_centroid.py`

also needs to be moved to the Examples section bellow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review, hoping it looks better now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants