Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX 1d sparse array validation #28988

Merged
merged 5 commits into from May 13, 2024

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented May 10, 2024

Fixes #28974 and the exception raised by check_array for scipy 1.14+

@ogrisel ogrisel added this to the 1.5 milestone May 10, 2024
Copy link

github-actions bot commented May 10, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: c256bdd. Link to the linter CI: here

@ogrisel ogrisel added Build / CI Quick Review For PRs that are quick to review labels May 10, 2024
doc/whats_new/v1.5.rst Outdated Show resolved Hide resolved
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@jeremiedbb jeremiedbb enabled auto-merge (squash) May 13, 2024 10:26
@jeremiedbb jeremiedbb merged commit bca3634 into scikit-learn:main May 13, 2024
28 checks passed
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request May 20, 2024
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@jeremiedbb jeremiedbb mentioned this pull request May 20, 2024
14 tasks
jeremiedbb added a commit that referenced this pull request May 21, 2024
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ CI failed on Linux_Nightly.pylatest_pip_scipy_dev (last failure: May 13, 2024) ⚠️
3 participants