-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added error handling for the case when Brotli is not imported scrapy#4697 #5480
base: master
Are you sure you want to change the base?
Conversation
I don't think it should be ImportError and I'm also not 100% sure it should be an exception at all (but actually running a callback here is not that useful as it certainly won't get the correctly decompressed response). |
Codecov Report
@@ Coverage Diff @@
## master #5480 +/- ##
==========================================
- Coverage 88.77% 88.57% -0.21%
==========================================
Files 163 163
Lines 10666 10668 +2
Branches 1818 1819 +1
==========================================
- Hits 9469 9449 -20
- Misses 922 942 +20
- Partials 275 277 +2
|
What could be an appopriate response by the program? |
What kind of response should the user receive? |
Could you also address the 1st bullet point of #4697? I imagine we should create a boolean I am also thinking that, instead of raising an exception if the response is br-encoded, we could remove |
Will try to implement your suggestions |
I added the necessary error generation. Are any further changes required?
Closes: #4697