Full typing for scrapy/contracts. #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6371 +/- ##
==========================================
+ Coverage 85.00% 88.98% +3.97%
==========================================
Files 161 162 +1
Lines 11962 12115 +153
Branches 1872 1725 -147
==========================================
+ Hits 10168 10780 +612
+ Misses 1512 1016 -496
- Partials 282 319 +37
|
Gallaecio
reviewed
May 28, 2024
| for line in method.__doc__.split("\n"): | ||
| line = line.strip() | ||
|
|
||
| if line.startswith("@"): | ||
| name, args = re.match(r"@(\w+)\s*(.*)", line).groups() | ||
| m = re.match(r"@(\w+)\s*(.*)", line) | ||
| assert m is not None |
There was a problem hiding this comment.
It could be None, though. Should we open a ticket to update it, e.g. to raise an exception about an invalid contract line being found?
There was a problem hiding this comment.
@wRAR @Gallaecio Should we raise an exception or just pass the unmatched regex using continue ?
There was a problem hiding this comment.
As I said in #6383, "I think we should just skip lines that don't match."
Gallaecio
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.