feat: add support for requesting "Specials" for TV Shows #3724
+52
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedNSidd
requested review from
sct,
TheCatLady,
danshilm and
OwsleyJr
as code owners
|
Can we remove the |
westdom
reviewed
Jan 10, 2024
westdom
reviewed
Jan 10, 2024
AhmedNSidd
force-pushed
the
feature-add-support-for-requesting-tv-show-specials
branch
from
2f3c080
to
3b0eb44
Compare
AhmedNSidd
commented
Jan 13, 2024
There was a problem hiding this comment.
@sct I made a commit that was responsible for undoing yarn.lock update. Thanks for letting me know.
@westdom Thank you for reviewing the PR. I responded to your suggestions, but made no code changes. Let me know if you have any more thoughts. Otherwise, I believe the conversations can be marked as resolved.
|
Any updates on this? |
This commit is responsible for adding support in Overseerr for requesting "Special" episodes for TV Shows. This request has become especially pertinent when you consider shows like "Doctor Who". These shows have Specials that are critical to understanding the plot of a TV show. fix sct#779
AhmedNSidd
force-pushed
the
feature-add-support-for-requesting-tv-show-specials
branch
from
0a857e8
to
919a384
Compare
|
@Panda260 No new updates.. I've updated the branch to be rebased on top of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is responsible for adding support in Overseerr for requesting "Special" episodes for TV Shows. This request has become especially pertinent when you consider shows like "Doctor Who". These shows have Specials that are critical to understanding the plot of a TV show.
Screenshot (if UI-related)
The TV Show Page
If you navigate to any show with Specials, you'll see the "Specials" season just before "Season 1".
NOTE: In this example, Doctor Who has 13 Seasons + Specials. However, in the header for the TV show, we STILL say that the show has 13 seasons (we don't include specials as a "Season" in the headers).
The TV Show Page (Request Modal)
NOTE: Instead of having the table say
Season 0which it would normally say for the Specials season, it says "Specials". Whether it should saySeason 0orSpecialsis a discussion that could be worth having for this PR, but I personally went withSpecialsfor more user-friendliness.The TV Show Page (Manage Series Sidebar)
NOTE: Instead of having the Badge say
0which it would normally say for the Specials season, it says "Specials". Whether it should say0orSpecialsis a discussion that could be worth having for this PR, but I personally went withSpecialsfor more user-friendliness.The Requests Page
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed