[Backport 5.4] Update tools/cqlsh submodule to v6.0.17 #18652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly a set of fixes in the area of ssl handling * tools/cqlsh 99b2b777...9d49b385 (21): > cqlshlib/sslhandling: fix logic of `ssl_check_hostname` > cqlshlib/sslhandling.py: don't use empty userkey/usercert > Dockerfile: noninteractive isn't enough for answering yet on apt-get > fix cqlsh version print > cqlshlib/sslhandling: change `check_hostname` deafult to False > Introduce new ssl configuration for disableing check_hostname > set the hostname in ssl_options.server_hostname when SSL is used > issue-73 Fixed a bug where username and password from the credentials file were ignored. > issue-73 Fixed a bug where username and password from the credentials file were ignored. > issue-73 > github actions: update `cibuildwheel==v2.16.5` > dist/debian: fix the trailer line format > `COPY TO STDOUT` shouldn't put None where a function is expected > Make cqlsh work with unix domain sockets > Bump python-driver version > dist/debian: add trailer line > dist/debian: wrap long line > Draft: explicit build-time packge dependencies > stop retruning status_code=2 on schema disagreement > Fix minor typos in the code > Dockerfile: apt-get update and apt-get upgrade to get latest OS packages Ref: scylladb#18590
🟢 CI State: SUCCESS✅ - Build Build Details:
|
|
@scylladb/scylla-maint can we have this merged ? |
denesb
pushed a commit
that referenced
this pull request
May 14, 2024
Mostly a set of fixes in the area of ssl handling * tools/cqlsh 99b2b777...9d49b385 (21): > cqlshlib/sslhandling: fix logic of `ssl_check_hostname` > cqlshlib/sslhandling.py: don't use empty userkey/usercert > Dockerfile: noninteractive isn't enough for answering yet on apt-get > fix cqlsh version print > cqlshlib/sslhandling: change `check_hostname` deafult to False > Introduce new ssl configuration for disableing check_hostname > set the hostname in ssl_options.server_hostname when SSL is used > issue-73 Fixed a bug where username and password from the credentials file were ignored. > issue-73 Fixed a bug where username and password from the credentials file were ignored. > issue-73 > github actions: update `cibuildwheel==v2.16.5` > dist/debian: fix the trailer line format > `COPY TO STDOUT` shouldn't put None where a function is expected > Make cqlsh work with unix domain sockets > Bump python-driver version > dist/debian: add trailer line > dist/debian: wrap long line > Draft: explicit build-time packge dependencies > stop retruning status_code=2 on schema disagreement > Fix minor typos in the code > Dockerfile: apt-get update and apt-get upgrade to get latest OS packages Ref: #18590 Closes #18652
1 task
this is the same set of fixes as in: we need to get them into 5.4/2024.1 |
|
This PR was queued two days ago. Closed by 393880f. |
|
@denesb "Closes" doesn't work with things not targeted for the default branch, so backport PR can't close issue, right ? |
I believe it needs to be done manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a set of fixes in the area of ssl handling
Ref: #18590