Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 5.2] repair: Introduce repair_partition_estimation_ratio config option #18657

Draft
wants to merge 1 commit into
base: branch-5.2
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 14, 2024

In commit 642f9a1 (repair: Improve estimated_partitions to reduce memory usage), a 10% hard coded estimation ratio is used.

This patch introduces a new config option to specify the estimation ratio of partitions written by repair out of the total partitions.

It is set to 0.1 by default.

Fixes #18615

(cherry picked from commit 340eae0)

Refs #18634

In commit 642f9a1 (repair: Improve
estimated_partitions to reduce memory usage), a 10% hard coded
estimation ratio is used.

This patch introduces a new config option to specify the estimation
ratio of partitions written by repair out of the total partitions.

It is set to 0.1 by default.

Fixes #18615

(cherry picked from commit 340eae0)

# Conflicts:
#	db/config.cc
#	db/config.hh
@mergify mergify bot requested a review from tgrabiec as a code owner May 14, 2024 02:42
@mergify mergify bot added the conflicts label May 14, 2024
@mergify mergify bot requested a review from nyh as a code owner May 14, 2024 02:42
Copy link
Author

mergify bot commented May 14, 2024

Cherry-pick of 340eae0 has failed:

On branch mergify/copy/branch-5.2/pr-18634
Your branch is up to date with 'origin/branch-5.2'.

You are currently cherry-picking commit 340eae007a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   repair/row_level.cc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   db/config.cc
	both modified:   db/config.hh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned asias May 14, 2024
@mergify mergify bot marked this pull request as draft May 14, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant