Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Add SpellChecker for requests #2777

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MykolaSauliak
Copy link

@MykolaSauliak MykolaSauliak commented Apr 23, 2021

What does this PR do?

Add new visual block (in results template) with a hint for correct request sentence
results.html and webapp.py are changed

image

Why is this change important?

other search engines have such feature
good to have I guess

How to test this PR locally?

make run

Author's checklist

Related issues

@unixfox
Copy link
Member

unixfox commented Apr 24, 2021

Did you test the behavior with the Google engine because if I remember well we already fetch the spellchecker of Google and show it as a suggestion?

@MykolaSauliak
Copy link
Author

MykolaSauliak commented Apr 24, 2021 via email

@kvch kvch requested a review from asciimoo May 2, 2021 17:56
@asciimoo
Copy link
Member

asciimoo commented May 3, 2021

Ohi! Thanks for the contribution. It is a useful and highly requested feature, however the implementation has some flaws. First, it doesn't support properly multiple languages currently, second it introduces a new dependency, what we try to avoid if it isn't necessary. I'm thinking about implementing it as a stand-alone plugin. In this case the extra dependency wouldn't cause an issue for all of our admins, anyone can decide if they want to install it. What do you think? If you agree, you can find an example stand-alone plugin here: https://github.com/asciimoo/searx_external_plugin_example

@MykolaSauliak
Copy link
Author

MykolaSauliak commented May 3, 2021 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants