This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
Support flask-babel 3.0 #3501
Open
Support flask-babel 3.0 #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
eryg-kai
force-pushed
the
flask-babel-3.0
branch
from
39ca3a1
to
7176dc8
Compare
jecarr
reviewed
Sep 5, 2023
| babel.init_app(app) | ||
| babel.localeselector(get_locale) | ||
| else: | ||
| babel.init_app(app, locale_selector=get_locale) |
There was a problem hiding this comment.
*Only commenting as I came across this recently too
If you're changing the versions in requirements.txt to be fixed (i.e. 3.1.0 which throws the AttributeError), is it worth having this if-else?
I'd think you either keep this approach but cater for (include) a lower version in the requirements file or have a cleaner diff (mine was this).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows searx to run with flask-babel 3.0. The driving motivation was to fix the package on NixOS which is not honoring dependency versions (NixOS/nixpkgs#216695).
The error:
The fix:
The way the locale selector is added has changed somewhat, and I needed to move
get_localeup to make use of it.Why is this change important?
I just want it to work with NixOS but keeping dependencies up to date is good in general.
How to test this PR locally?
I just ran
make testwith and without the updated requirements to make sure searx runs with both 2.0 and 3.0 without any errors.Related issues
Obviates #3497