Context path support for UI #4889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't worked with GitHub wikis before and am unsure how to approach this task, any guidance here? |
chrislusf
reviewed
Oct 4, 2023
| </head> | ||
| <body> | ||
| <div class="container"> | ||
| <div class="page-header"> | ||
| <h1> | ||
| <a href="https://github.com/seaweedfs/seaweedfs"><img src="/seaweedfsstatic/seaweed50x50.png"></img></a> | ||
| <a href="https://github.com/seaweedfs/seaweedfs"><img src="{{ $contextPath }}/seaweedfsstatic/seaweed50x50.png"></img></a> |
There was a problem hiding this comment.
Other links in this page to volume servers would not be able to have the contextPath fix.
I do not have a good solution for this though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
Creating subdomains for 3 different UIs may not be possible or feasible for a given project or company. This PR adds optional parameters to serve the filer & master UI's on a context path. Original idea found in this discussion idea.
How are we solving the problem?
Adding new configuration items
master.ui.contextPath,filer.ui.contextPath&volume.ui.contextPathwhen run viaweed serverandui.contextPathwhen servers are run individually.A new internal context-path variable is used to wrap UI endpoint registration & prefix rendered html documents.
How is the PR tested?
By hand on a development test server.
Checks