add sentry support to filer #5512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is already Prometheus metrics which we can use for error tracking. |
|
Hm. I don't see error-related metrics for weed server. I have plans however to add reporting to master/volume too. Looks like basic sentry.Init() #5410 is not enough. It would be much simpler to add hook to glog, but there is no builtin support in sentry-go. Only with 3rd party package https://github.com/yext/glog-contrib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
Reporing http errors to sentry collector
How are we solving the problem?
Capture http and some common errors and send it to sentry.
Sentry DSN if provided now required to be valid.
How is the PR tested?
With hope for gh actions.
Checks