fix issue: sometimes volume.fsck report 'volume not found' #5537
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ume server has multiple disk types
chrislusf
reviewed
Apr 26, 2024
| @@ -654,9 +658,10 @@ func (c *commandVolumeFsck) collectVolumeIds() (volumeIdToServer map[string]map[ | |||
| isEcVolume: true, | |||
| isReadOnly: true, | |||
| } | |||
| volumeCount += 1 | |||
There was a problem hiding this comment.
Shard count is different from volume count.
There was a problem hiding this comment.
Sorry, I don't have much information of seaweedfs.
I thought the count here is volume count. normal volume + ec volume (not shard)
Moreover, the reported value is not changed after code changes. (I have ec volumes too in my cluster)
Please let me know how can I fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
sometimes volume.fsck report 'volume not found' when a volume server has multiple disk types
How are we solving the problem?
reuse volumeId to VInfo map when is exists.
How is the PR tested?
I have tested on my cluster.
Checks