ipsec: Fix IPsec decrypt_esp for NAT-Traversal #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4370 +/- ##
==========================================
- Coverage 81.56% 81.56% -0.01%
==========================================
Files 352 352
Lines 83897 83900 +3
==========================================
- Hits 68431 68430 -1
- Misses 15466 15470 +4
|
|
Please provide a unit test as an example of what your PR fixes. |
|
Thanks for the PR ! it looks good, but could you please add a unit test ? |
|
Thanks, sure will add a unit test |
ImanAfaneh293
force-pushed
the
fix_ipsec_udp_transport
branch
from
c032968
to
f67a3eb
Compare
|
@gpotter2 could you please review |
|
Thanks. This test doesn't work though. You should test it locally using |
ImanAfaneh293
force-pushed
the
fix_ipsec_udp_transport
branch
from
f67a3eb
to
e24048e
Compare
|
I tested it locally and the test passed |
When having nat_header, encrypted.underlayer will return UDP/ESP, so when decrypting IPv6 packet, the decrypt packet will be return with nat_header (UDP), which will return a corrupted packet. Example: original packet: IPv6/TCP/Raw encrypted packet: IPv6/UDP/ESP Decrypted packet: IPv6/UDP/TCP/Raw Signed-off-by: Iman Afaneh <iafaneh@nvidia.com>
Signed-off-by: Iman Afaneh <iafaneh@nvidia.com>
ImanAfaneh293
force-pushed
the
fix_ipsec_udp_transport
branch
from
e24048e
to
39218a1
Compare
|
@gpotter2 could you please review |
1 similar comment
|
@gpotter2 could you please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having nat_header, encrypted.underlayer will return UDP/ESP, so when decrypting IPv6 packet, the decrypt packet will be return with nat_header (UDP), which will return a corrupted packet.
Example:
original packet:
IPv6/TCP/Raw
encrypted packet:
IPv6/UDP/ESP
Decrypted packet:
IPv6/UDP/TCP/Raw