[add]zk-kit/utils/ #782
Open
[add]zk-kit/utils/ #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedoor
requested changes
May 16, 2024
| @@ -9,7 +9,7 @@ | |||
| "dirBuild": "./build", | |||
| "optimization": 2, | |||
| "inspect": true, | |||
| "include": ["../../node_modules/circomlib/circuits", "../../node_modules/@zk-kit/binary-merkle-root.circom/src"], | |||
| "include": ["../../node_modules/circomlib/circuits", "../../node_modules/@zk-kit/circuits/circom"], | |||
There was a problem hiding this comment.
Suggested change
| "include": ["../../node_modules/circomlib/circuits", "../../node_modules/@zk-kit/circuits/circom"], | |
| "include": ["../../node_modules/circomlib/circuits", "../../node_modules/@zk-kit/binary-merkle-root.circom/src"], |
| @@ -24,7 +24,7 @@ | |||
| "access": "public" | |||
| }, | |||
| "dependencies": { | |||
| "@zk-kit/binary-merkle-root.circom": "1.0.0", | |||
| "@zk-kit/circuits": "0.2.4", | |||
There was a problem hiding this comment.
Suggested change
| "@zk-kit/circuits": "0.2.4", | |
| "@zk-kit/binary-merkle-root.circom": "1.0.0", |
| @@ -40,16 +45,16 @@ export default class SemaphoreEthers { | |||
| * @param options Configuration options for the ethers provider and the Semaphore contract. | |||
| */ | |||
| constructor(networkOrEthereumURL: EthersNetwork | string = defaultNetwork, options: EthersOptions = {}) { | |||
| checkParameter(networkOrEthereumURL, "networkOrSubgraphURL", "string") | |||
| requireString(networkOrEthereumURL, "networkOrSubgraphURL"); | |||
There was a problem hiding this comment.
; is not allowed in this repo. Please, run yarn format:write to format the code automatically.
Comment on lines
-239
to
-259
|
|
||
| describe("isGroupMember", () => { | ||
| it("Should return true because the member is part of the group", async () => { | ||
| const semaphore = new SemaphoreEthers() | ||
|
|
||
| const isMember = await semaphore.isGroupMember("42", "1") | ||
|
|
||
| expect(isMember).toBeTruthy() | ||
| }) | ||
| it("Should return false because the member is not part of the group", async () => { | ||
| ContractMocked.mockReturnValueOnce({ | ||
| hasMember: () => false | ||
| } as any) | ||
|
|
||
| const semaphore = new SemaphoreEthers() | ||
|
|
||
| const isMember = await semaphore.isGroupMember("48", "2") | ||
|
|
||
| expect(isMember).toBeFalsy() | ||
| }) | ||
| }) |
Comment on lines
-61
to
-84
|
|
||
| it("Should generate a Semaphore proof without passing the tree depth", async () => { | ||
| const group = new Group([1n, 2n, identity.commitment]) | ||
|
|
||
| proof = await generateProof(identity, group, message, scope) | ||
|
|
||
| expect(typeof proof).toBe("object") | ||
| expect(BigInt(proof.merkleTreeRoot)).toBe(group.root) | ||
| }, 70000) | ||
|
|
||
| it("Should throw an error because snarkArtifacts is not an object", async () => { | ||
| const group = new Group([1n, 2n, identity.commitment]) | ||
| const fun = () => generateProof(identity, group, message, scope, undefined, "hello" as any) | ||
|
|
||
| await expect(fun).rejects.toThrow("is not an object") | ||
| }) | ||
|
|
||
| it("Should throw an error because the message value is incorrect", async () => { | ||
| const group = new Group([1n, 2n, identity.commitment]) | ||
|
|
||
| const fun = () => generateProof(identity, group, Number.MAX_VALUE, scope, treeDepth) | ||
|
|
||
| await expect(fun).rejects.toThrow("overflow") | ||
| }) |
There was a problem hiding this comment.
I think this was to keep when you merged from the main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Dependencies about @zk-kit/utils and remplace checkParameters
Feature
dojoengine/book#272
Install @zk-kit/utils if is necessary
Related Issue(s)
Checklist
yarn formatandyarn lintwithout getting any errors