refactor: stable scroll behavior #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bang9
force-pushed
the
fix/scroll-position
branch
2 times, most recently
from
b827933
to
648fa7a
Compare
bang9
commented
May 20, 2024
| } | ||
| }, | ||
| }); | ||
|
|
There was a problem hiding this comment.
Moved to <InfiniteList />
bang9
commented
May 20, 2024
| scrollDistanceFromBottomRef.current = distanceFromBottom; | ||
| }, | ||
| }); | ||
|
|
There was a problem hiding this comment.
Moved to <InfiniteList />
AhyoungRyu
reviewed
May 21, 2024
HoonBaek
approved these changes
May 21, 2024
| @@ -42,7 +46,11 @@ const pubSubFactory = < | |||
| publish: (topic, info) => { | |||
| if (topics[topic]) { | |||
| topics[topic].forEach((fn) => { | |||
| setTimeout(() => fn(info !== undefined ? info : {}), 0); | |||
| if (opts?.publishSynchronous) { | |||
There was a problem hiding this comment.
What's the purpose of synchronous?
There was a problem hiding this comment.
When publishing events, you can choose between synchronous and asynchronous execution.
Here are the differences illustrated with examples:
Synchronous Execution:
fns.forEach(fn => fn());- Blocking: Each function runs to completion before the next one starts, potentially causing delays if any function takes time.
- Predictable Order: Functions execute in the exact order they are called.
Asynchronous Execution:
fns.forEach(fn => setTimeout(() => fn(), 0));- Non-blocking: Functions are scheduled to run after the current execution context, keeping the main thread free.
- Less Predictable Order: Functions might not execute in the strict order they are scheduled due to other asynchronous tasks.
src/modules/GroupChannel/components/MessageList/InfiniteList.tsx
Outdated
Show resolved
Hide resolved
bang9
force-pushed
the
fix/scroll-position
branch
from
0d9127c
to
bf1997b
Compare
AhyoungRyu
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
test link
before: https://sendbird-uikit-react.netlify.app/
after: https://deploy-preview-1094--sendbird-uikit-react.netlify.app/
ticket: CLNP-3273